fix: Unsafe access to std::vector without bounds check #3628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarDuran
requested review from
rrsettgast,
MelReyCG,
corbett5 and
wrtobin
as code owners
OmarDuran
added
ci: run CUDA builds
OmarDuran
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3628 +/- ##
===========================================
- Coverage 56.66% 56.66% -0.01%
===========================================
Files 1217 1217
Lines 105125 105123 -2
===========================================
- Hits 59567 59563 -4
- Misses 45558 45560 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CusiniM
reviewed
Apr 23, 2025
CusiniM
approved these changes
Apr 23, 2025
OmarDuran
changed the title
rrsettgast
requested changes
Apr 28, 2025
src/coreComponents/mesh/mpiCommunications/CommunicationTools.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Randolph Settgast <[email protected]>
Co-authored-by: Randolph Settgast <[email protected]>
rrsettgast
reviewed
Apr 28, 2025
Co-authored-by: Randolph Settgast <[email protected]>
rrsettgast
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure safe access in the L478 of file src/coreComponents/common/format/table/TableFormatter.cpp.
fix issue #3627.