-
Couldn't load subscription status.
- Fork 97
feat: Single-phase reactive transport combined with HPCReact #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Single-phase reactive transport combined with HPCReact #3634
Conversation
…inglePhaseReactiveTransport
…inglePhaseReactiveTransport
…inglePhaseReactiveTransport
…inglePhaseReactiveTransport
…d' into feature/singlePhaseReactiveTransportWithHPCReact
…ture/singlePhaseReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…d' into feature/singlePhaseReactiveTransportWithHPCReact
several cpu builds in CI still fail to compile, could you please have a look and fix it? |
Yes. I will fix it together with those cuda errors today or tomorrow. |
CPU builds should work now, although unit tests in HPCReact still fail because we need to update the reference solutions and clean up the codes there. For CUDA builds, I fixed some issues in data layouts but some other issues remain. I'll need more time and some help if any to pass the compile on CUDA. |
…eReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is expected to fail now until this PR: GEOS-DEV/HPCReact#9 is merged in HPCReact
…eReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
This branch aims to implement the single-phase reactive transport model into GEOS. The following tasks are listed for completion:
SinglePhaseReactiveTransportsolver (derived fromSinglePhaseBase) that contains all needed functions to solve the problem andSinglePhaseReactiveTransportFields.hppto store all necessary fieldsAccumulationKernelandFluxComputeKernelto assemble the local rhs and matrixReactiveSinglePhaseFluidconstitutive modeltestSinglePhaseReactiveTransportto verify the implementation of Jacobian matrixsurfaceArea(added but need test)