feat: Reuse LS factorization #3654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CusiniM
requested review from
rrsettgast,
paveltomin,
castelletto1,
frankfeifan,
jhuang2601,
Guotong-Ren and
victorapm
as code owners
CusiniM
added
the
ci: run integrated tests
victorapm
reviewed
May 8, 2025
| @@ -690,6 +692,7 @@ void HydrofractureSolver< POROMECHANICS_SOLVER >::assembleSystem( real64 const t | |||
| [&]( localIndex const, | |||
| SurfaceElementSubRegion & subRegion ) | |||
| { | |||
| std::cout << "Num of frac elements: " << subRegion.size() << std::endl; | |||
There was a problem hiding this comment.
Suggested change
| std::cout << "Num of frac elements: " << subRegion.size() << std::endl; |
victorapm
approved these changes
May 8, 2025
paveltomin
approved these changes
May 8, 2025
rrsettgast
approved these changes
May 9, 2025
castelletto1
approved these changes
May 9, 2025
| @@ -73,6 +73,7 @@ struct LinearSolverParameters | |||
| integer dofsPerNode = 1; ///< Dofs per node (or support location) for non-scalar problems | |||
| bool isSymmetric = false; ///< Whether input matrix is symmetric (may affect choice of scheme) | |||
| integer stopIfError = 1; ///< Whether to stop the simulation if the linear solver reports an error | |||
| bool reuseFactorization = true; ///< Whether to reuse the LU factorization or not | |||
There was a problem hiding this comment.
Not sure where it is used
CusiniM
commented
May 9, 2025
| @@ -73,6 +73,7 @@ struct LinearSolverParameters | |||
| integer dofsPerNode = 1; ///< Dofs per node (or support location) for non-scalar problems | |||
| bool isSymmetric = false; ///< Whether input matrix is symmetric (may affect choice of scheme) | |||
| integer stopIfError = 1; ///< Whether to stop the simulation if the linear solver reports an error | |||
| bool reuseFactorization = true; ///< Whether to reuse the LU factorization or not | |||
There was a problem hiding this comment.
Suggested change
| bool reuseFactorization = true; ///< Whether to reuse the LU factorization or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.