feat: Add enthalpy to PVT Driver output #3704
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkachuma
added
ci: run CUDA builds
dkachuma
requested review from
rrsettgast,
CusiniM,
corbett5,
wrtobin,
MelReyCG and
jhuang2601
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3704 +/- ##
========================================
Coverage 57.80% 57.80%
========================================
Files 1248 1248
Lines 107846 107862 +16
========================================
+ Hits 62342 62354 +12
- Misses 45504 45508 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhuang2601
approved these changes
Jun 17, 2025
MelReyCG
reviewed
Jun 24, 2025
src/coreComponents/constitutiveDrivers/fluid/multiFluid/PVTDriverRunTest.hpp
Outdated
Show resolved
Hide resolved
corbett5
approved these changes
Jun 24, 2025
MelReyCG
reviewed
Jun 25, 2025
Comment on lines
81
to
86
| integer const PHASE_FRACTION = TEMP + 2 + (outputCompressibility ? 1 : 0); | ||
| integer const PHASE_DENSITY = PHASE_FRACTION + numPhases; | ||
| integer const PHASE_VISCOSITY = outputMassDensity ? PHASE_DENSITY + 2*numPhases : PHASE_DENSITY + numPhases; | ||
| integer const PHASE_COMP = PHASE_VISCOSITY + numPhases; | ||
| integer const PHASE_MASS_DENSITY = PHASE_DENSITY + (outputMassDensity ? numPhases : 0); | ||
| integer const PHASE_VISCOSITY = PHASE_MASS_DENSITY + numPhases; | ||
| integer const PHASE_ENTHALPY = PHASE_VISCOSITY + (outputEnthalpy ? numPhases : 0); | ||
| integer const PHASE_COMP = PHASE_ENTHALPY + numPhases; |
There was a problem hiding this comment.
As this code passes unit tests I may be wrong, but I still have the feeling that PHASE_ENTHALPY and PHASE_COMP are not well defined. If those variables are the start indexes, shouldn't PHASE_ENTHALPY only be offset by the end of viscosity values? (PHASE_VISCOSITY + numPhases?)
And by the same design, shouldn't PHASE_COMP be at the end of enthalpies, which are enabled by outputEnthalpy? (which would give PHASE_ENTHALPY + (outputEnthalpy ? numPhases : 0))
MelReyCG
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the enthalpy to the output of the
PVTDriverif the fluid is thermal.