-
Notifications
You must be signed in to change notification settings - Fork 95
feat: Adding signal and external error detection & output #3722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MelReyCG
wants to merge
89
commits into
GEOS-DEV:develop
Choose a base branch
from
amandinehry:feature/rey/signal-and-external-error-managment
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: Adding signal and external error detection & output #3722
MelReyCG
wants to merge
89
commits into
GEOS-DEV:develop
from
amandinehry:feature/rey/signal-and-external-error-managment
+3,304
−1,370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… link between GEOS_THROW_CTX_IF and LVARRAY_THROW_IF_TEST( EXP, MSG, TYPE )
… in try/catch statements Problem: Retrieves everything that was thrown, so not just the message.
…/catch in main)": remove useless try/catch
…y spaces. The previous condition checked whether an argument was present and whether the option was immediately followed by a value like -test"value", which excluded valid cases like -test "value" et -test "value".
…rnal errors + adding docs
…amandinehry/create-yaml-file-and-structure
…o feature/rey/signal-and-external-error-managment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on Amandine work on Adding error YAML file in GEOS (PR #3690), and aims at adding a detection & management inside GEOS of 1. Error signals, 2. External errors from dependencies, in order to be able to manage & output them in the log & error YAML file.
Managing those external errors gives us the opportunity to:
This PR also prevent the stacktrace to be cut by other ranks message, which could previously happen on a signal.
We can imagine adding later some tag for each dependency (system, LvArray, Hypre, ...) to quickly identify / filter issues source.
Message to reviewers:
As this PR is based on the #3690, which is on a fork of GEOS, the modifications of both PR are visible. I also opened a PR on the fork, showing only the modification of this PR, but all systems of this repo are missing (code owners, CI...).
Did I miss something?
Still, the keypoints are:
ExternalErrorHandler
, a singleton which redirectsstderr
messages into internal GEOS logger &ErrorHander
,ExternalErrorHandler
is based onOutputStreamDeviation
to redirect external messages,src/coreComponents/common/initializeEnvironment.cpp
,ErrorHandler
/ErrorMsg
for signals.