Skip to content

refactor: move printFieldInfo into setSystemSetupTimestamp so that all solvers print it #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 10, 2025
Merged

refactor: move printFieldInfo into setSystemSetupTimestamp so that all solvers print it #3762

merged 8 commits into from
Sep 10, 2025

Conversation

@paveltomin
Copy link
Collaborator

No description provided.

@paveltomin paveltomin self-assigned this Aug 11, 2025
@paveltomin paveltomin added type: cleanup / refactor Non-functional change (NFC) flag: ready for review flag: no rebaseline Does not require rebaseline labels Aug 11, 2025
@paveltomin paveltomin marked this pull request as ready for review August 11, 2025 20:40
@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Sep 9, 2025
@paveltomin paveltomin added the ci: run code coverage enables running of the code coverage CI jobs label Sep 10, 2025
@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.23%. Comparing base (6573089) to head (b3e6124).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3762   +/-   ##
========================================
  Coverage    59.23%   59.23%           
========================================
  Files         1285     1285           
  Lines       111773   111772    -1     
========================================
+ Hits         66207    66208    +1     
+ Misses       45566    45564    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paveltomin paveltomin merged commit f7fd188 into develop Sep 10, 2025
28 checks passed
@paveltomin paveltomin deleted the pt/move-printfieldinfo branch September 10, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrsettgast rrsettgast rrsettgast approved these changes

@castelletto1 castelletto1 castelletto1 approved these changes

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren Guotong-Ren is a code owner

Assignees

@paveltomin paveltomin

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paveltomin @rrsettgast @castelletto1