- 
                Notifications
    You must be signed in to change notification settings 
- Fork 97
feat: refactor partitioners #3847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            bd713
  wants to merge
  42
  commits into
  develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
feature/bd713/enhancePartitioner
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    herve-gross
  
              
              approved these changes
              
                  
                    Oct 6, 2025 
                  
              
              
            
            
45ad26f    to
    5ce56de      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    changes XML input
  
    ci: run integrated tests
  Allows to run the integrated tests in GEOS CI 
  
    flag: ready for review
  
    flag: requires rebaseline
  Requires rebaseline branch in integratedTests 
  
    type: cleanup / refactor
  Non-functional change (NFC) 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
This PR introduces a complete refactoring of GEOS's mesh partitioning system with a new architecture that separates partitioning algorithms (
engines) from domain decomposition strategies (partitioners).In practice, a new
DomainPartitionerabstract base class is introduced with two main specialized branches:The mesh partitioners leverage low-level graph partitioner engines that are independent from MPI communication:
A
PartitionerManageris introduced for creating and managing partitioner instances.XML Changes
Partitioning configuration moved from mesh-embedded to dedicated
<Partitioner>section.Before:
After:
Default behavior
If no
partitioneris prescribed, an appropriate default is selected based on mesh type:CartesianPartitionerCellGraphPartitionerwith ParMetisTo skip graph partition optimization, explicitly use
engine="noop".Testing & Rebaseline
Due to XML schema changes a rebaseline is required.
However no numerical impact is expected.
All currently failing integrated tests are due to structural changes such as: