Skip to content

Conversation

@dkachuma
Copy link
Contributor

@dkachuma dkachuma commented Oct 6, 2025

This PR adds well solver support to the coupled flow and conforming fracture solver.

Adds a new solver of type CompositionalMultiphaseReservoirPoromechanicsConformingFractures which combines the fracture solver withe the flow and well solver. This follows the SinglePhaseReservoirPoromechanicsConformingFractures solver.

The added test case replaces the source flux from the multiphasePoromechanics_FaultModel_smoke.xml model with an injection well.

@dkachuma dkachuma self-assigned this Oct 6, 2025
@dkachuma dkachuma added flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Oct 20, 2025
Copy link
Contributor

@herve-gross herve-gross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this capability to the documentation?

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.94%. Comparing base (c1615a5) to head (afd96ec).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ics/MultiphasePoromechanicsConformingFractures.cpp 0.00% 10 Missing ⚠️
...ysics/CompositionalMultiphaseReservoirAndWells.cpp 0.00% 6 Missing ⚠️
...ysics/CompositionalMultiphaseReservoirAndWells.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3849      +/-   ##
===========================================
- Coverage    58.95%   58.94%   -0.02%     
===========================================
  Files         1326     1326              
  Lines       109506   109523      +17     
===========================================
- Hits         64556    64555       -1     
- Misses       44950    44968      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paveltomin paveltomin merged commit 3fde58e into develop Oct 30, 2025
24 of 28 checks passed
@paveltomin paveltomin deleted the dkachuma/multiphase-contact branch October 30, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants