Skip to content

Conversation

@tjb-ltk
Copy link
Contributor

@tjb-ltk tjb-ltk commented Oct 13, 2025

feat: Formalize definition of well constraints to

  1. allow more than 2 constraints per well
  2. minimize restrictions on rate type
  3. allow production/injection constraints for one well (future capability)
  4. improve code for constraint processing in general and also needed for well estimator
  5. current implementation requires schema changes, script provided scripts/convert_well_schema.py

ToDo

  1. add validation based on current implementation rules
  2. add control switch logging
  3. organized constraint hpp and cpp so all methods are in similar order
  4. submit new input files

Subsequent PR's based on this PR

  1. New constraint activation/test models (Liquid, needs phase name validation, single phase mass rate, ...)
  2. change balance equation scaling, should be current rate?, not constraint rate, this will change results but will clean up residual check code
  3. well estimator
  4. well head pressure constraint

tjb-ltk and others added 6 commits October 14, 2025 06:47
…t compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml
…d convert compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml"

This reverts commit fa61ab1.
@tjb-ltk tjb-ltk added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Oct 24, 2025
@tjb-ltk tjb-ltk marked this pull request as ready for review October 24, 2025 16:30
@tjb-ltk tjb-ltk changed the title Feature/byer3/well constraints feat: feature/byer3/well constraints Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run integrated tests Allows to run the integrated tests in GEOS CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants