Skip to content

fix: vtk - add a missing file path error #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

fix: vtk - add a missing file path error #3869

merged 2 commits into from
Oct 30, 2025
+14 −14

Conversation

@paveltomin
Copy link
Collaborator

also remove unused

@paveltomin paveltomin self-assigned this Oct 16, 2025
@paveltomin paveltomin added the type: bug Something isn't working label Oct 16, 2025
@paveltomin paveltomin added flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Oct 16, 2025
@paveltomin
Copy link
Collaborator Author

@OmarDuran, @rrsettgast, @wrtobin review anyone?

OmarDuran
OmarDuran approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@OmarDuran OmarDuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks clean. As a side comment, consider adding a unit or integration test to ensure that both filePath and dataSourceName inputs are correctly validated after the refactor.

@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: no rebaseline Does not require rebaseline and removed flag: ready for review labels Oct 30, 2025
@paveltomin paveltomin merged commit 412546e into develop Oct 30, 2025
25 of 26 checks passed
@paveltomin paveltomin deleted the pt/vtk-file-error branch October 30, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wrtobin wrtobin wrtobin approved these changes

@OmarDuran OmarDuran OmarDuran approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

Assignees

@paveltomin paveltomin

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paveltomin @wrtobin @OmarDuran