fix: temporary fix UB on historyBaseCollection #3886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 03bf257.
arng40
requested review from
CusiniM,
MelReyCG,
OmarDuran,
castelletto1,
dkachuma,
herve-gross,
jhuang2601,
paveltomin,
rrsettgast and
wrtobin
as code owners
arng40
added
type: bug
MelReyCG
approved these changes
Oct 29, 2025
arng40
added
flag: ready for review
ci: run CUDA builds
This reverts commit 7d193b2.
arng40
removed
the
ci: run integrated tests
MelReyCG
added
the
ci: run integrated tests
MelReyCG
reviewed
Nov 3, 2025
| { | ||
|
|
||
| GEOS_THROW_IF( targetTokens.size() <= 4, | ||
| GEOS_FMT( " Object Path '{}' does not targeting any element sub region", |
Contributor
There was a problem hiding this comment.
Suggested change
| GEOS_FMT( " Object Path '{}' does not targeting any element sub region", | |
| GEOS_FMT( "Object Path '{}' does not target any element sub-region.", |
…EOS-DEV/GEOS into bugfix/dudes/UB-packCollection
herve-gross
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segmentation fault when we enter a wrong
objectPathto thePackCollectioningetTargetObject().For now I output a temporary error log to avoir this seg fault and in a future PR, this fonction will be refactor due to it's lack of clarity and contains potential UB