feat: add FillPartialArrays vtk filter and paraview plugin #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…artialattribute, it is still nan by default
…utes in the fillallpartialattributes function
| from geos.mesh.processing.FillPartialArrays import FillPartialArrays | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( "onpoints, attributesList, value_test", [ |
There was a problem hiding this comment.
Why not defining multiple parameters instead of one tuple containing them all 3 ?
Co-authored-by: paloma-martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends of the improve of the utils functions of geos-mesh #109
This PR add the possibility to fill a partial arrays with values
- the value to fill can be choose, defaults to nan
+ Modifications of the functions FillPartialAttributes and FillAllPartialAtributes to add the possibility of choosing the value
+ Modifications of the tests of the functions FillPartialAttributes and FillAllPartialAtributes
- several attributes can be fill in the same time but with the same value.
close #104