refactor: Move and refactor Mohr Circle plugin #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
paloma-martinez
requested review from
RomainBaville,
alexbenedicto and
jafranc
RomainBaville
approved these changes
Nov 14, 2025
Contributor
RomainBaville
left a comment
RomainBaville
left a comment
There was a problem hiding this comment.
Thank for you work, it looks good to me
| if logger is None: | ||
| logger = logging.getLogger( "getVtkOriginalCellIds" ) | ||
|
|
||
| if not logger.hasHandlers(): |
Contributor
There was a problem hiding this comment.
You may use logger.handlers and check if it is empty. With logger.hasHandler() if any parent of the logger have one it will return True even if the logger do not have any handler
| # Logger | ||
| self.logger: logging.Logger = logging.getLogger( "MohrCircle" ) | ||
| self.logger.setLevel( logging.INFO ) | ||
| if not self.logger.hasHandlers(): |
Contributor
There was a problem hiding this comment.
Same as before, you may check the number of handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists mainly in the move of the
MohrCircleplugin and related utils functions fromgeos-posptogeos-pv, as part of the EPIC #54