refactor: Move VTK utilities from geos-posp to geos-mesh #75
Conversation
|
|
||
| dependencies = [ | ||
| "vtk >= 9.3", | ||
| "vtk == 9.3", |
There was a problem hiding this comment.
What is the reason for using specificaly 9.3 ?
There was a problem hiding this comment.
It seems Paraview 5.13 cannot open correctly VTU files generated by VTK > 9.3 at the moment.
As a lot of GEOS users use Paraview, I think it's better to stay with this version of the package as long as it is not handled...
mlemayTTE
left a comment
mlemayTTE
left a comment
There was a problem hiding this comment.
Very good job to set unit tests up for all utilities.
There was a problem hiding this comment.
Utilities from geos.mesh.utils.filters and geos.mesh.utils.helpers may be gathered in thematic modules. For instance, a module may contains all attribute helpers (need to set the name "attribute" or "array") and another module may contains other utilities (including getBounds*, to_vtk_id_list, vtk_iter, extractBlock, mergeBlocks, computeCellCenterCoordinates, extractSurfaceFromElevation).
| if keepPartialAttributes: | ||
| fillAllPartialAttributes( input, False ) | ||
| fillAllPartialAttributes( input, True ) |
There was a problem hiding this comment.
What is happening in this part?
There was a problem hiding this comment.
We are filling both cells (False) and point attributes (True)
| from vtkmodules.vtkCommonDataModel import vtkUnstructuredGrid, vtkPolyData, vtkPlane | ||
| from vtkmodules.vtkFiltersCore import vtk3DLinearGridPlaneCutter | ||
|
|
||
| __doc__ = """ Generic VTK utilities.""" |
There was a problem hiding this comment.
You may explain a bit more what type of functions this file (same for other files) contains.
alexbenedicto
deleted the
pmartinez/refactor/MoveMultiblockInspectorAndVtkUtils
branch
Close #69
vtkwas causing conflict issues in package import.geos-meshpackage to ci typing-check.