feat: Pass cycleNumber to execute/output/collect calls #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
av-novikov
changed the title
|
I think this is a very good idea. My only concern is with the other PR GEOS-DEV/GEOS#3631 . |
Victor-M-Gomes
approved these changes
Apr 25, 2025
|
Cannot help on pygeos-tools use, but from code point of view looks ok. |
alexbenedicto
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cycleNumber is required for execute/output/collect calls in PyHistoryCollection.cpp, PyHistoryOutput.cpp, PyVTKOutput.cpp and PySolver.cpp. Currently, it is not passed from Python, but awkwardly calculated as
int cycleNumber = int(round( time/dt ));which result in, for example, wrong indexation of VTK snapshots in case of dynamically changing timestep.This PR passes cycleNumber from Python to affected C++ calls and support changes in examples.
Goes with GEOS: PR3631