Skip to content

Conversation

mlemayTTE
Copy link
Contributor

This PR add a wrapper to vtkMeshQuality filter to compute all metric at once and export summary report. It also extend the squish index to all types of cell and add mesh quality metrics.

paloma-martinez and others added 30 commits April 4, 2025 15:48
add tests of helpers

add test data files
@paloma-martinez paloma-martinez removed their request for review July 24, 2025 12:13
Copy link
Collaborator

@alexbenedicto alexbenedicto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to correct, the plugins work.
The .rst file for PVPlugins needs to be updated to take into account the new architecture.


# update sys.path to load all GEOS Python Package dependencies
geos_pv_path: Path = Path( __file__ ).parent.parent.parent
geos_pv_path: Path = Path( __file__ ).parent.parent.parent.parent.parent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to change our way to handle paths with ParaView in a new PR, I will make an issue for that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree.

@paloma-martinez
Copy link
Collaborator

A few features will be handled in a future PR :

  • Better logging of plugins and filters.
  • Boxplots instead of min-max ranges for the statistic figure of QualitySummaryMetrics class.
  • Better autoscale of that figure

@alexbenedicto I added a brief documentation of the plugins that have been moved for now. I think it's best to dedicate a future PR to the improvement of the documentation of all the plugins as this one is already very large...

Copy link
Collaborator

@alexbenedicto alexbenedicto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, I also prefer the choice of combining the MeshQuality filters into a single one.
Also the new figures being output are way more readable now with that new scaling.

@alexbenedicto alexbenedicto merged commit 0fa4d8f into main Aug 11, 2025
43 checks passed
@alexbenedicto alexbenedicto deleted the lemay/feature/add_tte_mesh_stats branch August 11, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants