Add ROCm CI #321
Add ROCm CI #321
Conversation
| TPL_DOCKERFILE: docker/Stanford/Dockerfile | ||
| DOCKER_ROOT_IMAGE: matteofrigo5/sherlock-gcc10.1.0-openmpi4.1.2-cuda12.4.0-openblas0.3.10-zlib1.2.11-cmake3.31.4-no-geosx:0.0.1 | ||
| SPEC: "%[email protected]~pygeosx~openmp" | ||
| SPEC: "~pygeosx~openmp %c,cxx,fortran=[email protected]" |
There was a problem hiding this comment.
Here also, that's the new way spack v1 is handling compilers. See https://github.com/spack/spack/releases#compiler-dependencies
| @@ -0,0 +1,152 @@ | |||
| spack: | |||
There was a problem hiding this comment.
we should not use centos anymore. rocky is the replacement for rhel builds.
There was a problem hiding this comment.
Good! That simplifies things
There was a problem hiding this comment.
I assume I can remove the centos build then, otherwise let me know :)
|
|
||
| gcc: | ||
| externals: | ||
| - spec: [email protected] languages:='c,c++,fortran' |
There was a problem hiding this comment.
isn't the default to install all languages?
There was a problem hiding this comment.
I think so, but this was recommended somewhere in the documentation files that I was reading for spack. @bmhan12 could you confirm what is the best thing to do here?
There was a problem hiding this comment.
I think so, but this was recommended somewhere in the documentation files that I was reading for spack. @bmhan12 could you confirm what is the best thing to do here?
With Spack 1.0, that is the correct way now to specify compilers (compilers are now treated as packages).
However, in addition, if you want to make sure Spack picks your external compiler like we have set before Spack 1.0, you need to add toolchain(s): https://spack.readthedocs.io/en/latest/toolchains_yaml.html
I have a wip branch working through the Spack 1.0/toolchain changes here: https://github.com/GEOS-DEV/thirdPartyLibs/tree/feature/han12/spack_v1_noapi
| gcc: | ||
| externals: | ||
| - spec: [email protected] languages:='c,c++,fortran' | ||
| prefix: /opt/rh/gcc-toolset-13/root/usr/ | ||
| extra_attributes: | ||
| compilers: | ||
| c: /opt/rh/gcc-toolset-13/root/usr/bin/gcc | ||
| cxx: /opt/rh/gcc-toolset-13/root/usr/bin/g++ | ||
| fortran: /opt/rh/gcc-toolset-13/root/usr/bin/gfortran | ||
| clang: | ||
| externals: | ||
| - spec: clang@17 languages:='c,c++' | ||
| prefix: /usr | ||
| extra_attributes: | ||
| compilers: | ||
| c: /usr/bin/clang-17 | ||
| cxx: /usr/bin/clang++-17 | ||
|
|
There was a problem hiding this comment.
What is the reason for the change?
There was a problem hiding this comment.
That's the new way spack v1 is handling compilers. More info here: https://github.com/spack/spack/releases#compiler-dependencies
v1.0.2and internally distributed spack packages accordingly.developas of Sep/25hdf5andtrilinosspack packages. Instead. rely on spack_packages (upstream)2025.09.0RAJA/CHAI/Umpire/Camp suiteUbuntu 24.04 + gcc 13.3.0 + ROCm 6.4.3Docker image