Skip to content

chore(sdk): bump submodule to afbca02#3173

Closed
smk762 wants to merge 8 commits intodevfrom
universal-mac-builds
Closed

chore(sdk): bump submodule to afbca02#3173
smk762 wants to merge 8 commits intodevfrom
universal-mac-builds

Conversation

@smk762
Copy link
Collaborator

@smk762 smk762 commented Oct 7, 2025

Test branch for https://github.com/KomodoPlatform/komodo-defi-sdk-flutter/pull/236 to confirm binaries from new source domain function as expected in wallet builds.

Do not merge

Please tick off below for each platform confirmed tested for launch/standard wallet ops

  • Windows
  • Linux
  • MacOS (pre-silicon)
  • MacOS (silicon)
  • ios
  • android
  • browser (any opsys)

Please note your actual OS/version used to test in comments, along with any quirks or regressions identified.


Note

Updates SDK submodule SHA and adds device_info_plus to iOS/macOS pods with corresponding lockfile changes.

  • SDK:
    • Bump sdk submodule to 5e6a1063.
  • iOS/macOS Pods:
    • Add device_info_plus to ios/Podfile.lock and macos/Podfile.lock (dependencies, external sources, checksums).
    • Update komodo_defi_framework checksum on macOS.

Written by Cursor Bugbot for commit f1ee957. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch universal-mac-builds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Visit the preview URL for this PR (updated for commit f1ee957):

https://walletrc--pull-3173-merge-pt5bpbii.web.app

(expires Thu, 16 Oct 2025 18:14:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

cursor[bot]

This comment was marked as outdated.

@CharlVS CharlVS added QA Ready for QA Testing and removed do not merge labels Oct 9, 2025
@CharlVS
Copy link
Collaborator

CharlVS commented Oct 9, 2025

Closing in favor of #3175 which updates the SDK submodule for universal macOS KDF support, new CDN sources, and regenerated Pods, with a clearer title/description.

New PR: #3175

@CharlVS CharlVS closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Ready for QA Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants