This repository was archived by the owner on May 29, 2024. It is now read-only.
Direct issuance of ECR vLEI credential by a legal entity#20
Open
nkongsuwan wants to merge 2 commits intoGLEIF-IT:mainfrom
Open
Direct issuance of ECR vLEI credential by a legal entity#20nkongsuwan wants to merge 2 commits intoGLEIF-IT:mainfrom
nkongsuwan wants to merge 2 commits intoGLEIF-IT:mainfrom
Conversation
Signed-off-by: Nuttawut Kongsuwan <win@finema.co>
Signed-off-by: Nuttawut Kongsuwan <win@finema.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made an attempt to fix issue #17.
I added a new function
createDirectEngagementContextRoleCredentialtole.tsand the following classes and interfaces inedges.tsI have also added more tests accordingly. I am not sure if the naming for these edge classes and interfaces are appropriate.