Skip to content

feat: add failure timeout and successful validation logs #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentbull merged 1 commit into from
May 16, 2025
Merged

feat: add failure timeout and successful validation logs #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
'hio==0.6.14',
'multicommand==1.0.0',
'blake3==0.4.1',
'falcon==3.1.3',
'falcon==4.0.2',
'http_sfv==0.9.9'
],
extras_require={
Expand Down
7 changes: 5 additions & 2 deletions src/sally/core/handling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ def processPresentations(self):
now = helping.nowUTC()
logger.info(f"looking for credential {said}")
if now - dater.datetime > datetime.timedelta(minutes=self.timeout):
logger.info(f"presentation {said} timed out")
self.cdb.iss.rem(keys=(said,))
continue

Expand All @@ -237,10 +238,12 @@ def processPresentations(self):
raise kering.ValidationError(f"credential {creder.said} is of unsupported schema"
f" {creder.schema} from issuer {creder.issuer}")
except kering.ValidationError as ex:
logger.error(f"credential {creder.said} from issuer {creder.issuer} failed validation: {ex}")
logger.error(f"Credential {creder.said} from issuer {creder.issuer} failed validation: {ex}")
else:
logger.info(f"Credential {said} from issuer {creder.issuer} passed validation")
self.cdb.recv.pin(keys=(said, dater.qb64), val=creder)
finally:
logger.info(f"Removing presentation {said} from escrow after successful validation")
self.cdb.iss.rem(keys=(said,))

def processRevocations(self):
Expand Down Expand Up @@ -296,7 +299,7 @@ def processReceived(self, db, action):
else: # revocation of credential
data = self.revokePayload(creder)

logger.info(f"Sending {action} of {type_to_name[creder.schema]} to {self.hook} with SAID {said}")
logger.info(f"Sending action {action} of {type_to_name[creder.schema]} to {self.hook} with SAID {said}")
logger.info(f"Payload: \n{json.dumps(data, indent=1)}\n")

self.request(creder.said, resource, action, actor, data)
Expand Down
Loading