Skip to content

production#15

Merged
Sunja-An merged 4 commits intomainfrom
develop
Apr 12, 2026
Merged

production#15
Sunja-An merged 4 commits intomainfrom
develop

Conversation

@Sunja-An
Copy link
Copy Markdown
Contributor

No description provided.

@Sunja-An Sunja-An self-assigned this Apr 12, 2026
@Sunja-An Sunja-An added the 🎉 DEPLOY Deploying our service 🙀 label Apr 12, 2026
@Sunja-An Sunja-An merged commit 3c30232 into main Apr 12, 2026
1 check passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements Riot Games verification by adding a riot.txt file, configuring a Docker volume mount, and updating the Nginx template to serve the file. Feedback indicates that the .gitignore entry is incorrect and unnecessary for a tracked file, and the riot.txt file needs to contain the actual verification token to be functional.


.env.staging

/riot/riot.txt No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The path /riot/riot.txt in .gitignore does not match the actual file path nginx/static/riot.txt created in this PR. Furthermore, since the file is being tracked in the repository, adding it to .gitignore will not ignore it unless it is first removed from the git index. If the intention is to track this file, this line should be removed to avoid confusion.

@@ -0,0 +1 @@

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The riot.txt file is currently empty. Riot Games verification requires a specific token string (usually a UUID) to be present in this file. An empty file will cause the verification process to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 DEPLOY Deploying our service 🙀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant