Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

373 deploying the sample data fails #393

Merged
merged 3 commits into from
Feb 6, 2023
Merged

373 deploying the sample data fails #393

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfe5a59
Remove unnecessary LogicException so that sample data deploys correctly
rowan04 Jan 9, 2023
f1174c1
Add check that the XML file parsed correctly
rowan04 Jan 9, 2023
e10c89c
Add comment explaining $error object
rowan04 Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/Doctrine/deploy/AddServiceGroups.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@
$stFileName = __DIR__ . "/" . $GLOBALS['dataDir'] . "/ServiceGroups.xml";
$sts = simplexml_load_file($stFileName);

// Checking the XML file has parsed correctly
if ($sts === false) {
echo "There were errors parsing the XML file.\n";
// $error will be an object of the libXMLError class
foreach (libxml_get_errors() as $error) {
echo $error->message;
}
exit;
}

foreach($sts as $st) {
$instance = new ServiceGroup();
$name = "";
Expand All @@ -36,9 +46,10 @@
$scope = (string) $value;
break;
default:
throw new LogicException("Unknown ServiceGroup key in input XML: ". $key);
break;
}
}

$instance->setName($name);
$instance->setDescription($desc);
$instance->setMonitored($monitored);
Expand Down