Skip to content

add view depend#198

Merged
UltraProdigy merged 4 commits intomasterfrom
view-depend
Apr 15, 2026
Merged

add view depend#198
UltraProdigy merged 4 commits intomasterfrom
view-depend

Conversation

@ABKQPO
Copy link
Copy Markdown
Member

@ABKQPO ABKQPO commented Apr 11, 2026

78ccaaa4e2391c7d38d52c8030c7eef1 fd4dcdc1aaae32b97baf0b80f365a51b

Copy link
Copy Markdown
Member

@UltraProdigy UltraProdigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small breakage, & also- not necessary- but it might make sense to have the buttons dissapear when there is nothing to go underneath.

Otherwise this feature is awesome, I love it.

Comment thread src/main/java/betterquesting/client/gui2/GuiQuest.java
@ABKQPO ABKQPO requested a review from UltraProdigy April 15, 2026 00:31
Copy link
Copy Markdown
Member

@UltraProdigy UltraProdigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fixes look good... one last thing- completely missed it before

The lists aren't filtering out quests that either don't exist within a line (In folder "NoQuestLine" - like trigger quests) or that are hidden (ZPM quests for example). The triggers should be filtered out since the user can never reach them. As for the hidden quests if you can find a way to filter them out before they're revealed that would be nice- but if not then I don't think it's a big deal, it just brings the user to a page view it doesn't break anything.

@ABKQPO
Copy link
Copy Markdown
Member Author

ABKQPO commented Apr 15, 2026

Okay, fixes look good... one last thing- completely missed it before

The lists aren't filtering out quests that either don't exist within a line (In folder "NoQuestLine" - like trigger quests) or that are hidden (ZPM quests for example). The triggers should be filtered out since the user can never reach them. As for the hidden quests if you can find a way to filter them out before they're revealed that would be nice- but if not then I don't think it's a big deal, it just brings the user to a page view it doesn't break anything.

image

Copy link
Copy Markdown
Member

@UltraProdigy UltraProdigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible PR. Code looks great and this is a wonderful feature. Super excited to have this in game

@UltraProdigy UltraProdigy merged commit b0644df into master Apr 15, 2026
1 check passed
@UltraProdigy UltraProdigy deleted the view-depend branch April 15, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants