Made lava sigil not damaging self during craft in conformity with water sigil#121
Merged
Dream-Master merged 2 commits intoGTNewHorizons:masterfrom Mar 6, 2026
Merged
Conversation
koolkrafter5
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Water sigil contains self as an "emptied container". That makes it non-consumable in crafts. Lava sigil instead contains a copy of self damaged by 2000. That causes weird behavior described in GTNewHorizons/GT-New-Horizons-Modpack#21707
If the player tries to craft infinity armor or final blood orb, he will also create "damaged" lava sigil. It is identical to usual, except that it cannot be used in crafting anymore.
While it could've been a way to "charge LP" for crafts - it currently does not do that and only creates confusion.
This PR removes that extra damage and makes it NC the same way as the water sigil is.
Also removed Zenscript from the dependency as it looks like it is not used anymore and moved to the museum, thus failing the build if present in dependencies.