[Memory-opti:fix leak] Properly use client / common proxies to fix 5 memory leaks#97
Merged
Conversation
…efer allocation of arrays
…nced in the CommonProxy
# Conflicts: # src/main/java/com/brandon3055/draconicevolution/client/ClientProxy.java
Kogepan229
reviewed
Apr 25, 2026
Alexdoru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit history, mostly made the fields of the event handlers non static and accessed via an instance in the common or server proxy. Said instance is set to null when appropriate to prevent memory leaks e.g. when server stops or when client disconnects.
Fix memory leaks :
static Map<EntityPlayer, DataUtils.XZPair<Float, Integer>>TileDislocatorInhibitorstatic final HashMap<World, HashSet<TileDislocatorInhibitor>>, this one caused a giant memory leak because everytime you change dimensions, it will keep all the previousWorldClientuntil your game runs out of memory (Memory Leak/Crash every time I change dimensions GT-New-Horizons-Modpack#19536 (comment))CustomArmorHandlerstatic Map<EntityPlayer, Boolean>DragonChunkLoaderstatic Map<EntityChaosGuardian, Ticket>ParticleHandler#theWorldBug fix :
Screenshot of what your heap looks like after changing dimension multiple times while using magnet inhibitors :
