Implemented the Advance-Milestone#94
Open
KAMALDEEN333 wants to merge 3 commits intoGalactiGuild:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the Advanced Milestone Validation
Description
Contributor
Category: Escrow Enhancement
Context
Current milestone validation relies on validator subjective approval. More robust validation mechanisms using oracles or on-chain verification would improve trust and automation.
Problem
Subjective milestone approval can lead to disputes and delays. Objective validation criteria would improve efficiency and reduce human error in approval processes.
Solution Requirements
Integrate with oracle services for external data validation
Implement on-chain verification where possible
Create fallback manual approval for complex cases
Implementation Guidelines
Research Soroban-compatible oracle solutions
Design validation schemas for different milestone types
Implement fallback mechanisms for oracle failures
Ensure gas efficiency despite external calls
Expected outcome
Milestones can be validated automatically based on objective criteria
Oracle integration handles external data verification
Manual approval remains for subjective milestones
Validation failures are handled gracefully
Validation Criteria
Oracle data is securely verified
Gas costs are acceptable for validation
Fallback mechanisms work when oracles fail
Security prevents oracle manipulation
closes #37