chore: Remove async-graphql integration#717
Merged
Merged
Conversation
Contributor
📊 Performance ReportCommit: 15e3349 Cala Performance Benchmark Results (non-representative)Criterion Benchmark Results (single-threaded)
Load Testing Results (parallel-execution)
Note: Performance results may vary based on system resources and database state. Last updated by commit 15e3349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
graphqlfeatures fromcala-ledgerandcala-ledger-core-typesasync-graphql/base64from Cala manifests and lockfileVerification
SQLX_OFFLINE=true cargo check -p cala-ledger-core-typesSQLX_OFFLINE=true cargo check -p cala-ledgerSQLX_OFFLINE=true cargo check -p cala-ledger --all-featurescargo tree -p cala-ledger -e features -i async-graphqlreports no matching packageCompanion Lana change moves the GraphQL API representation to Lana-owned wrapper enums.
Note
Medium Risk
Removes the optional GraphQL feature surface (
async-graphqlderives and cursor encoding) and related dependencies, which is potentially breaking for downstream consumers that enabledgraphqlfeatures, but does not change core ledger logic.Overview
Removes
async-graphqlintegration fromcala-ledgerandcala-ledger-core-typesby deleting thegraphqlfeature flags and all related enum derives andCursorTypeimplementations.Updates workspace and crate manifests plus
Cargo.lockto dropasync-graphql,base64, and their transitive dependencies, leaving cursor structs as plainserde-serializable types.Reviewed by Cursor Bugbot for commit 15e3349. Bugbot is set up for automated code reviews on this repo. Configure here.