chore(deps): bump es-entity to 0.10.37#724
Merged
Merged
Conversation
es-entity 0.10.37 contains the direction-aware NULL fallback in cursor WHERE clauses for nullable sort columns (GaloyMoney/es-entity#137) and the opt-in `nullable` column attribute for non-Option<T> Rust types (GaloyMoney/es-entity#138). The macro change in #137 alters the DESC SQL emitted for `Option<...>` columns — for cala-ledger this affects `Account.external_id` and `AccountSet.external_id` pagination. New fingerprints replace the old ones in `cala-ledger/.sqlx/`; semantics are unchanged for non-NULL rows and now also include NULL rows on page 2+ for DESC (previously dropped). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
📊 Performance ReportCommit: ecdc30e Cala Performance Benchmark Results (non-representative)Criterion Benchmark Results (single-threaded)
Load Testing Results (parallel-execution)
Note: Performance results may vary based on system resources and database state. Last updated by commit ecdc30e |
jirijakes
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
es-entityfrom 0.10.36 → 0.10.37 to pick up two macro changes:WHEREclause for nullable sort columns. Fixes a DESC NULLS LAST pagination bug where rows withNULLin the sort column were silently dropped from page 2+. ASC behavior unchanged.nullablecolumn attribute for non-Option<T>Rust types whosesqlx::Encodemaps one variant to SQL NULL. Not used by cala-ledger today; landing it here unblocks downstream consumers (e.g. lana-bank'sLoanToCollateralRatiocolumn).Why this is a one-line bump but a five-file diff
#137changes the DESC SQL emitted for anyOption<...>list_bycolumn. In cala-ledger that'sAccount.external_idandAccountSet.external_id. The macro now emitsinstead of
so the cached SQL fingerprints in
cala-ledger/.sqlx/change. Same logical query, different hash. Regenerated viamake sqlx-prepare.Downstream
This release unblocks GaloyMoney/lana-bank#5898, which can then declare its
loan_to_collateral_ratiocolumn with the newnullableattribute instead of leaking storage shape into the entity accessor.Test plan
make sqlx-prepare— regenerates 5 cached queries (4Option<String>DESC pagination, 1job_executionsquery whose fingerprint shifted from a parameter-cast adjustment).SQLX_OFFLINE=true cargo check --workspace— clean.🤖 Generated with Claude Code
Note
Medium Risk
Changes generated list/pagination SQL for accounts and account sets (data completeness on paged APIs) plus job poller query shapes; low direct code churn but behavior-sensitive query semantics.
Overview
Bumps
es-entityfrom 0.10.36 to 0.10.37 in the workspace and lockfile, with no application Rust changes beyond refreshedcala-ledger/.sqlxoffline query metadata.The upgrade pulls in macro-generated SQL fixes for DESC NULLS LAST cursor pagination on nullable sort columns (notably
external_idoncala_accountsandcala_account_sets). The generatedWHEREclause now uses a direction-aware NULL fallback so rows with NULLexternal_idare not dropped on later pages; ASC behavior is unchanged. Four cached list queries reflect that predicate change.Two
job_executionscached queries were also regenerated:execute_at/alive_atnow bind as separatetimestamptzparameters instead of reusing an earlier placeholder, which only updates SQL fingerprints for offlinesqlxchecks.Reviewed by Cursor Bugbot for commit ecdc30e. Bugbot is set up for automated code reviews on this repo. Configure here.