feat: add count_for_filters and count methods via #[es_repo(count)]#118
Open
nicolasburtey wants to merge 1 commit intomainfrom
Open
feat: add count_for_filters and count methods via #[es_repo(count)]#118nicolasburtey wants to merge 1 commit intomainfrom
nicolasburtey wants to merge 1 commit intomainfrom
Conversation
Add opt-in `count` attribute to the EsRepo derive macro. When enabled, generates `count_for_filters()` and `count()` methods that execute SELECT COUNT(*) queries using the same filter columns as list_for_filters. Also derives Clone on generated filter structs to support passing filters to both list and count calls. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
240bde9 to
529e72a
Compare
Member
|
Blanket clone won’t work because we can’t garuantee all fields to be clone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opt-in
countattribute to theEsRepoderive macro. When#[es_repo(count)]is set, generates:count_for_filters(filters) -> Result<i64>— SELECT COUNT(*) with the same filter columns aslist_for_filterscount() -> Result<i64>— convenience wrapper callingcount_for_filters(Default::default())Also derives
Cloneon generated filter structs.Usage
Companion PRs
🤖 Generated with Claude Code