chore: replace docker-compose with nix process-compose for dev deps#62
chore: replace docker-compose with nix process-compose for dev deps#62vindard wants to merge 1 commit into
Conversation
Aligns obix's dev tooling with the lana-bank docker-free pattern shared with es-entity and job: contributors no longer need Docker (or podman) installed locally. `start-deps` now runs Postgres directly via `process-compose-flake`, with data stored under `.nix-deps/`. - Adds `process-compose-flake` flake input - Defines `nix-deps-base` (process-compose stack: `core-pg` + `setup-db`) and `setup-db-dev` packages - Updates `nextest-runner` to use the new stack instead of `podman-compose-runner` - Drops `docker-compose.yml` and `nix/podman-runner.nix` - Drops `docker-compose`, `ytt`, `podman`, `podman-compose` from `nativeBuildInputs` - Updates `Makefile` `start-deps` / `clean-deps` / `setup-db` to call `nix run .#...` CI is unchanged: `.github/workflows/test.yml` and `ci/pipeline.yml` already invoke `nix run .#nextest`, and the runner's internals are what we updated. Refs GaloyMoney/volcano-wip#772. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b14664e. Configure here.
| NAME="$1" PORT="$2" PGUSER="$3" DB="$4" | ||
| PGDATA="$PWD/.nix-deps/$NAME" | ||
|
|
||
| mkdir -p "$PWD/.nix-deps" |
There was a problem hiding this comment.
.nix-deps/ directory not added to .gitignore
Medium Severity
The PR introduces a new .nix-deps/ directory (containing PostgreSQL data files, process-compose logs, and PID files) but doesn't add it to .gitignore. A developer running git add . could accidentally commit a large PostgreSQL data directory and runtime artifacts to the repository.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b14664e. Configure here.
| signal = 2; | ||
| timeout_seconds = 10; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Migration process lacks readiness probe risking race condition
Low Severity
The setup-db process in baseProcesses has no readiness_probe, so project is-ready --wait may consider it "ready" as soon as it enters the "Running" state—before sqlx migrate run actually completes. Both the nextest-runner and Makefile start-deps gate test execution on is-ready --wait, creating a potential race where tests begin against an unmigrated database.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b14664e. Configure here.
1 participant
Summary
Aligns obix's dev tooling with the lana-bank docker-free pattern shared with es-entity (#GaloyMoney/es-entity#140) and job (#GaloyMoney/job#109): contributors no longer need Docker (or podman) installed locally. `start-deps` now runs Postgres directly via `process-compose-flake`, with data stored under `.nix-deps/`.
CI is unchanged: both `.github/workflows/test.yml` and `ci/pipeline.yml` already invoke `nix run .#nextest`, and the runner's internals are what we updated.
Refs
Test plan
🤖 Generated with Claude Code
Note
Low Risk
Changes only local dev and CI dependency orchestration; application code and production paths are untouched.
Overview
Replaces Docker/Podman-based local Postgres with a Nix + process-compose stack so dev and CI tests no longer depend on container runtimes.
flake.nixaddsprocess-compose-flake, a localpg-starthelper (initdb/data under.nix-deps/), packagesnix-deps-base(core-pgthensetup-dbviasqlx migrate), andsetup-db-dev.nextest-runnernow brings that stack up with readiness waits instead ofpodman-compose-runner/ wait4x. Dev shell drops docker/podman-related tools in favor ofprocess-compose.Makefiletargets callnix run .#nix-deps-baseandnix run .#setup-db-dev;reset-deps/test-in-cino longer run the old shell retry loop for migrations (migrations are tied to the composesetup-dbprocess onstart-deps).Removes
docker-compose.ymlandnix/podman-runner.nix.Reviewed by Cursor Bugbot for commit b14664e. Bugbot is set up for automated code reviews on this repo. Configure here.