Skip to content

Add HttpRequest type aliases for varying engine versions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add HttpRequest type aliases for varying engine versions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
775edec
Update RequestHandler.h with aliases
bartdominiak Oct 20, 2023
5e78e5b
Update RequestHandler.h with aliases
bartdominiak Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Source/GameSwiftSdk/Private/RequestHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,18 @@


#if ENGINE_MAJOR_VERSION == 4 && ENGINE_MINOR_VERSION <= 24
TSharedRef<IHttpRequest> FRequestHandler::SendRequest(
using HttpRequestRef = TSharedRef<IHttpRequest>;
#else
TSharedRef<IHttpRequest, ESPMode::ThreadSafe> FRequestHandler::SendRequest(
using HttpRequestRef = TSharedRef<IHttpRequest, ESPMode::ThreadSafe>;
#endif
FString FullUrl, FString Method, const FString callBody, const FString accessToken, bool ExpectsWwwResponse)
{

HttpRequestRef FRequestHandler::SendRequest(
FString FullUrl,
FString Method,
const FString& callBody,
const FString& accessToken,
bool ExpectsWwwResponse
) {
auto HttpRequest = FHttpModule::Get().CreateRequest();
HttpRequest->SetVerb(Method);
HttpRequest->SetURL(FullUrl);
Expand Down
13 changes: 9 additions & 4 deletions Source/GameSwiftSdk/Public/RequestHandler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,17 @@ class FRequestHandler
{
public:
#if ENGINE_MAJOR_VERSION == 4 && ENGINE_MINOR_VERSION <= 24
static TSharedRef<IHttpRequest> SendRequest(
using HttpRequestRefType = TSharedRef<IHttpRequest>;
#else
static TSharedRef<IHttpRequest, ESPMode::ThreadSafe> SendRequest(
using HttpRequestRefType = TSharedRef<IHttpRequest, ESPMode::ThreadSafe>;
#endif
FString FullUrl, FString Method, const FString callBody, const FString accessToken,
bool ExpectsWwwResponse = false);
static HttpRequestRefType SendRequest(
const FString& FullUrl,
const FString& Method,
const FString& callBody,
const FString& accessToken,
bool ExpectsWwwResponse = false
);

static bool DecodeRequest(FHttpResponsePtr HttpResponse, bool bSucceeded, FJsonObject& ResultObject,
FBaseSdkFailResponse& OutError);
Expand Down