Reeling Rods Module

[runcows]

Reeling Rods adds new fishing rod interactions to various entities that fishing bobbers can hook onto.

• Pull Paintings off walls
• Reel in items from Item Frames, and then the item frame off the wall
• Snatch leashed mobs from leash knots
• Try and fail to pull in an end crystal (it explodes)

Adds a new enchantment for fishing rods which allows you to

• Separate chest boats and all minecart variants
• Steal items from allays

This would be the first gm4 custom enchantment using the vanilla system. It is intentionally not a metallurgy shamir.

Functionally, the enchantment allows additional pulling options without entirely preventing the vanilla action of pulling the entity towards the player. All of the interactions possible without the enchantment, in vanilla simply do nothing but use durability.

Additional (unimplemented) ideas for this that I am unsure of and want feedback on are:

• Stealing armor or hand items from entities that can have them. This presents a gameplay balance issue that I am not knowledgable enough to have any insight on. It also could just be annoying for players in multiplayer.
• ADDED: Dismounting mobs riding others. This would be added for parity with Bedrock Edition. As according to the Minecraft Wiki, "in Bedrock Edition, the hooked mob dismounts".
• ADDED: Pulling shulkers over a block towards the player. This would need checks to see if the shulker could be supported after being moved. Currently, in vanilla shulkers do nothing on being fished.

[runcows]

Build for 1.21.1 is currently failing due to the boat entity type changes made in 1.21.2 and the #minecraft:boat entity type tag not existing then.

Edit: Fixed.

[runcows]

Discussion from meeting:

• Need to add a not adventure mode check to advancements
• Additional ideas (Probably ok to implement previous ones)
  • ADDED: + Steal potions from witches
  • ADDED: + Steal items from villagers hands? Needs some penalty
  • Armor from mobs maybe shouldn't be a guaranteed drop
  • If additional ideas implemented, using enchantment makes sense since its a different utility / ability from the base rod + balance issues
• Theft Moderation could be an issue with servers (Might be a good time to look into Add Opt-In Logging to Modules Usable as Griefing Tools #1037 )
• Enchantment could be exclusive to mending, so your yoinking days are limited
• Probably more discussion needed for gameplay balance of mechanics