Switch pictures for different mode #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inserted a picture of my shoppinglist
This picture will be shown if the users has darkmode active
Steffeeeen1234
commented
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are many users who use the darkmode also for github, it is really nice if your pictures support dark mode and light mode. I had trupple to visualize your picture untill I switched to light mode.
I was experimenting a little and found this:
https://www.stefanjudis.com/notes/how-to-define-dark-light-mode-images-in-github-markdown/
In this pull requested I have implemented, that if the user has darkmode turned on he gets a picture which tells him to turn of darkmode t the the staes picture correctly. It would be really greate if you can prepare a states picture with darkmode support.
btw. sorry for the amount of commits. I did a few change only for myself and didn't wanted to put them in your project. Thats why it is a little messed up.