Add BIP32 44 49 84 - #74
Open
bdescamps wants to merge 5 commits into
Open
Conversation
Author
|
Hi @q9f can you take time to read this PR. |
Collaborator
|
I'm sorry, I'm currently very limited in reviewing this. Can you make the tests pass and then I will give it a quick look? |
Author
|
Thanks for your reply. Spec tests are ok on my computer. It seems that reported test errors, are linked to account payment. |
Author
|
Hi @q9f , i have retry spec on local ( without errors). Spec seems to be just blocked here due to billing issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#73