Merge pull request #3 from FranzAlbers/fix/double-float-conversion

Fixed type conversions: Removed unnecessary float to double conversion
GeneSysElektronik · Feb 6, 2023 · 4fd4873 · 4fd4873
2 parents d9e9a42 + b0fc591
commit 4fd4873
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/adma_ros2_driver/include/adma_ros2_driver/parser/parser_utils.hpp b/adma_ros2_driver/include/adma_ros2_driver/parser/parser_utils.hpp
@@ -2,7 +2,7 @@
 
 #include <iostream>
 
-const float PI=3.1415926535897932384626433832795028841971f;
+const double PI=3.1415926535897932384626433832795028841971;
 
 bool getbit(unsigned char byte, int position);
-float getScaledValue(int32_t rawValue, float lsbFactor);
+double getScaledValue(int32_t rawValue, double lsbFactor);
diff --git a/adma_ros2_driver/src/parser/parser_utils.cpp b/adma_ros2_driver/src/parser/parser_utils.cpp
@@ -10,7 +10,7 @@ bool getbit(unsigned char byte, int position) // position in range 0-7
     return (byte >> position) & 0x1;
 }
 
-float getScaledValue(int32_t rawValue, float lsbFactor)
+double getScaledValue(int32_t rawValue, double lsbFactor)
 {
-    return rawValue * lsbFactor;
+    return double(rawValue) * lsbFactor;
 }