Skip to content

102 plot decision #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 75 commits into from
Jun 27, 2025
Merged

102 plot decision #136

merged 75 commits into from
Jun 27, 2025

Conversation

audreyyeoCH
Copy link
Collaborator

close #102

Copy link
Contributor

github-actions bot commented May 12, 2025

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              81       3  96.30%   32, 62, 136
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      166       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                63       5  92.06%   106-110
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            53       0  100.00%
R/plotOc.R                  50       2  96.00%   94-95
R/postprob.R                34       1  97.06%   106
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumBetaDiff.R             80      15  81.25%   102-120
R/sumTable.R                36       0  100.00%
TOTAL                     2330     398  82.92%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/plotDecision.R      -26     -79  +100.00%
R/sumBetaDiff.R       +80     +15  +81.25%
TOTAL                 +54     -64  +3.27%

Results for commit: 3afebef

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 12, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ocPostprob 💚 $26.30$ $-1.51$ $0$ $0$ $0$ $0$
ocPredprobDist 💚 $96.56$ $-1.80$ $0$ $0$ $0$ $0$
plotDecision 👶 $+1.86$ $+10$ $0$ $0$ $0$
plotOc 💚 $219.99$ $-6.42$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ocPredprobDist 💚 $62.12$ $-1.34$ ocPredprobDist_gives_higher_PrFutility_with_more_futility_looks
plotDecision 👶 $+1.86$ plotDecision_gives_a_correct_result
plotOc 💚 $50.42$ $-1.67$ h_get_dataframe_oc_gives_correct_results_for_ocPredprobDist_when_relativeDelta_TRUE
plotOc 💚 $108.28$ $-5.62$ plotOc_gives_expected_results_for_ocPredprobDist_with_different_relativeDelta_status
sumbetadiff 👶 $+0.01$ sumBetaDiff_gives_a_error_when_at_least_one_alpha_0
sumbetadiff 👶 $+0.10$ sumBetaDiff_works_as_expected
sumbetadiff 💀 $0.01$ $-0.01$ sumbetadiff_gives_a_error_when_at_least_one_alpha_0
sumbetadiff 💀 $0.11$ $-0.11$ sumbetadiff_works_as_expected

Results for commit 668880f

♻️ This comment has been updated with latest results.

audreyyeoCH and others added 2 commits May 12, 2025 20:18
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
@audreyyeoCH audreyyeoCH marked this pull request as draft May 12, 2025 22:19
audreyyeoCH and others added 4 commits May 13, 2025 10:45
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented May 13, 2025

Hi @danielinteractive before I do snaps, could you kindly review this plot from the example file please ? I used the same colours as plotBetaDiff :
image

Edit, the last previous version here
image

Edit, will add "%"

@audreyyeoCH audreyyeoCH marked this pull request as ready for review May 13, 2025 10:34
Copy link
Contributor

github-actions bot commented May 13, 2025

Unit Tests Summary

    1 files     20 suites   6m 12s ⏱️
  136 tests   136 ✅ 0 💤 0 ❌
1 311 runs  1 311 ✅ 0 💤 0 ❌

Results for commit 3afebef.

♻️ This comment has been updated with latest results.

@danielinteractive
Copy link
Collaborator

Looks good @audreyyeoCH !

@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented May 13, 2025

thanks @danielinteractive, it's ready for another review
copying updated plot :
image

@audreyyeoCH
Copy link
Collaborator Author

yaaaaaaaayyyy 🥳

@audreyyeoCH audreyyeoCH merged commit 5a55c40 into main Jun 27, 2025
23 checks passed
@audreyyeoCH audreyyeoCH deleted the 102_plotDecision branch June 27, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

102_plotDecision
3 participants