Skip to content

feat: Guests Web Midfis Part 1#239

Open
zaydaanjahangir wants to merge 10 commits intomainfrom
feat/guests-web-midfis
Open

feat: Guests Web Midfis Part 1#239
zaydaanjahangir wants to merge 10 commits intomainfrom
feat/guests-web-midfis

Conversation

@zaydaanjahangir
Copy link
Copy Markdown
Contributor

@zaydaanjahangir zaydaanjahangir commented Apr 1, 2026

Description

1st part of guests web midfis update, added initial drawer implementation as well as updating the guests lists.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

What Changed?

  • Added the guest drawer
  • Update the lists and filter look

Testing & Validation

How this was tested

  1. Tested locally
  2. Added some tests

Screenshots/Recordings

Screenshot 2026-04-04 at 2 34 25 AM Screenshot 2026-04-04 at 2 34 39 AM

Unfinished Work & Known Issues

  • None, this PR is complete and production-ready
  • The following items are intentionally deferred:
    • The rest of the midfi (split up so it's easier to review/digest)


Notes & Nuances

  • Data fetching for the actual drawer might change with backend updates
  • Filter popover will probably change as well to support multi select for filtering?

Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 39.28571% with 187 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.95%. Comparing base (6033a10) to head (1ea8154).

Files with missing lines Patch % Lines
...s/web/src/components/guests/GuestFilterPopover.tsx 8.00% 115 Missing ⚠️
...ents/web/src/components/guests/GuestListHeader.tsx 0.00% 21 Missing ⚠️
...nts/web/src/components/guests/GuestProfileCard.tsx 0.00% 17 Missing ⚠️
clients/web/src/hooks/use-debounce.ts 0.00% 9 Missing ⚠️
...ts/web/src/components/guests/PreviousStaysCard.tsx 0.00% 8 Missing ⚠️
...ts/web/src/components/guests/guest-drawer-state.ts 88.57% 4 Missing ⚠️
backend/internal/repository/guests.go 0.00% 3 Missing ⚠️
...ients/web/src/components/guests/GuestSearchBar.tsx 0.00% 3 Missing ⚠️
clients/web/src/utils/dates.ts 62.50% 3 Missing ⚠️
...ients/web/src/components/guests/GuestNotesCard.tsx 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   20.37%   13.95%   -6.42%     
==========================================
  Files          39      118      +79     
  Lines        1453     3963    +2510     
  Branches        0       40      +40     
==========================================
+ Hits          296      553     +257     
- Misses       1153     3406    +2253     
  Partials        4        4              
Flag Coverage Δ
backend 20.34% <0.00%> (-0.03%) ⬇️
mobile 84.00% <ø> (?)
web 8.74% <39.67%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/internal/handler/guests.go 97.43% <ø> (ø)
...s/web/src/components/guests/GuestDetailsDrawer.tsx 100.00% <100.00%> (ø)
...eb/src/components/guests/GuestSpecialNeedsCard.tsx 2.77% <100.00%> (ø)
.../components/guests/HousekeepingPreferencesCard.tsx 5.26% <100.00%> (ø)
clients/web/src/components/ui/PageShell.tsx 97.87% <100.00%> (ø)
...ents/web/src/routes/_protected/guests.$guestId.tsx 20.00% <100.00%> (ø)
.../web/src/components/guests/GuestQuickListTable.tsx 97.72% <96.00%> (ø)
clients/web/src/routes/_protected/guests.index.tsx 16.66% <50.00%> (ø)
...ients/web/src/components/guests/GuestNotesCard.tsx 0.00% <0.00%> (ø)
backend/internal/repository/guests.go 0.00% <0.00%> (ø)
... and 8 more

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zaydaanjahangir zaydaanjahangir changed the title Feat/guests web midfis feat: Guests Web Midfis Part 1 Apr 1, 2026
@zaydaanjahangir zaydaanjahangir marked this pull request as ready for review April 4, 2026 06:48
@Dao-Ho
Copy link
Copy Markdown
Contributor

Dao-Ho commented Apr 4, 2026

will review once first pr is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants