Skip to content

feat: Notifications Shared Client#288

Merged
danctila merged 2 commits intomainfrom
danc/notifications-web
Apr 7, 2026
Merged

feat: Notifications Shared Client#288
danctila merged 2 commits intomainfrom
danc/notifications-web

Conversation

@danctila
Copy link
Copy Markdown
Contributor

@danctila danctila commented Apr 7, 2026

Description

This is taken from the mobile notifications PR #282 so web and mobile can both be worked on in parallel.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Related Issue(s)

Related to #231

What Changed?

  • Added shared Notification types and API hooks (useGetNotifications, useMarkNotificationRead, useMarkAllNotificationsRead, usePostDeviceToken)

Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

@danctila danctila self-assigned this Apr 7, 2026
@danctila danctila added the feature Introduces a new and complete feature label Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 1.89%. Comparing base (701420a) to head (812935a).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (701420a) and HEAD (812935a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (701420a) HEAD (812935a)
backend 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #288       +/-   ##
==========================================
- Coverage   19.66%   1.89%   -17.77%     
==========================================
  Files          46      85       +39     
  Lines        2253    3268     +1015     
  Branches        0      24       +24     
==========================================
- Hits          443      62      -381     
- Misses       1796    3206     +1410     
+ Partials       14       0       -14     
Flag Coverage Δ
backend ?
mobile 84.00% <ø> (?)
web 0.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 131 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danctila danctila marked this pull request as ready for review April 7, 2026 18:16
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐐

@danctila danctila merged commit 38d0344 into main Apr 7, 2026
14 checks passed
@danctila danctila deleted the danc/notifications-web branch April 7, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Introduces a new and complete feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants