Skip to content

Revert "Revert "hotel id header injection - MERGE AFTER ONBOARDING/CL…#307

Closed
manueltorres0 wants to merge 6 commits intomainfrom
restore-hotel-id-changes
Closed

Revert "Revert "hotel id header injection - MERGE AFTER ONBOARDING/CL…#307
manueltorres0 wants to merge 6 commits intomainfrom
restore-hotel-id-changes

Conversation

@manueltorres0
Copy link
Copy Markdown
Contributor

…ERK ORGS (#287)" (#294)"

This reverts commit 4c81c42.

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Related Issue(s)

Closes #
Related to #

What Changed?

Testing & Validation

How this was tested

Screenshots/Recordings

Unfinished Work & Known Issues

  • None, this PR is complete and production-ready
  • The following items are intentionally deferred:



Notes & Nuances



Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: ...

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.77%. Comparing base (84d0c57) to head (9d8cc72).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
clients/web/src/routeTree.gen.ts 0.00% 7 Missing ⚠️
clients/web/src/routes/no-org.tsx 0.00% 4 Missing ⚠️
clients/web/src/routes/__root.tsx 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (84d0c57) and HEAD (9d8cc72). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (84d0c57) HEAD (9d8cc72)
backend 1 0
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #307      +/-   ##
========================================
- Coverage   8.47%   1.77%   -6.71%     
========================================
  Files        139      92      -47     
  Lines       5909    3556    -2353     
  Branches      24      24              
========================================
- Hits         501      63     -438     
+ Misses      5392    3493    -1899     
+ Partials      16       0      -16     
Flag Coverage Δ
backend ?
mobile 84.00% <ø> (ø)
web 0.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
clients/web/src/routes/__root.tsx 0.00% <0.00%> (ø)
clients/web/src/routes/no-org.tsx 0.00% <0.00%> (ø)
clients/web/src/routeTree.gen.ts 0.00% <0.00%> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manueltorres0 manueltorres0 deleted the restore-hotel-id-changes branch April 10, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant