Skip to content

Add links to projection table - #1004

Merged
seisman merged 4 commits into
masterfrom
docs-proj-links
Mar 5, 2021
Merged

Add links to projection table#1004
seisman merged 4 commits into
masterfrom
docs-proj-links

Conversation

@maxrjones

Copy link
Copy Markdown
Member

Description of proposed changes

Adds links to the individual projection examples from the projections table.

Fixes #1003

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones
maxrjones requested review from a team March 4, 2021 16:56
Comment thread examples/projections/table/README.txt Outdated
Comment thread examples/projections/table/README.txt Outdated
@seisman seisman added this to the 0.3.1 milestone Mar 4, 2021
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 4, 2021
@seisman

seisman commented Mar 5, 2021

Copy link
Copy Markdown
Member

It seems we don't have examples for Oblique Mercator projection (-JO), right?

@maxrjones

Copy link
Copy Markdown
Member Author

It seems we don't have examples for Oblique Mercator projection (-JO), right?

There are no Oblique Mercator examples.

@willschlitzer

Copy link
Copy Markdown
Contributor

It seems we don't have examples for Oblique Mercator projection (-JO), right?

There are no Oblique Mercator examples.

I didn't understand the GMT documentation so I skipped making a PyGMT example 😬

@seisman

seisman commented Mar 5, 2021

Copy link
Copy Markdown
Member

It seems we don't have examples for Oblique Mercator projection (-JO), right?

There are no Oblique Mercator examples.

I didn't understand the GMT documentation so I skipped making a PyGMT example 😬

Could you open an issue and see if someone is interested in making the example?

@seisman seisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman
seisman merged commit 1690928 into master Mar 5, 2021
@seisman
seisman deleted the docs-proj-links branch March 5, 2021 23:00
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add links between projection table and projection examples

4 participants