Skip to content

Exclude more links in Link Checker - #1017

Merged
seisman merged 3 commits into
masterfrom
fix-link-checker
Mar 9, 2021
Merged

Exclude more links in Link Checker#1017
seisman merged 3 commits into
masterfrom
fix-link-checker

Conversation

@seisman

@seisman seisman commented Mar 7, 2021

Copy link
Copy Markdown
Member

Description of proposed changes

See #1015 for the latest Link Checker reports.

Exclude three links in the Link Checker:

  • hackmd.io/@pygmt (Invalid mail address: hackmd.io/@pygmt) (lychee is not doing well with @ signs)
  • zenodo.org/badge/DOI/10.5281/zenodo [404 Not Found]
  • doi.org/10.5281/zenodo [404 Not Found]

Fixes #1015

See https://github.com/GenericMappingTools/pygmt/pull/1017/checks?check_run_id=2051772694 for the CI reports.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 7, 2021
@seisman seisman added this to the 0.3.1 milestone Mar 7, 2021
@seisman
seisman requested a review from a team March 7, 2021 19:34
@seisman
seisman marked this pull request as ready for review March 8, 2021 14:28
@seisman
seisman merged commit 74d7e6e into master Mar 9, 2021
@seisman
seisman deleted the fix-link-checker branch March 9, 2021 00:55
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Exclude three links in the Link Checker:

- hackmd.io/@pygmt (Invalid mail address: hackmd.io/@pygmt) (lychee is not doing well with @ signs)
- zenodo.org/badge/DOI/10.5281/zenodo [404 Not Found]
- doi.org/10.5281/zenodo [404 Not Found]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link Checker Report

1 participant