Skip to content

Clarifying resolutions of relief grids - #1454

Merged
seisman merged 4 commits into
GenericMappingTools:mainfrom
srijac:srijac-patch-1
Aug 21, 2021
Merged

Clarifying resolutions of relief grids#1454
seisman merged 4 commits into
GenericMappingTools:mainfrom
srijac:srijac-patch-1

Conversation

@srijac

@srijac srijac commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

Description of proposed changes

To clarify resolutions of relief grids requiring region parameter

Fixes #1375

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Aug 19, 2021
@weiji14 weiji14 added this to the 0.5.0 milestone Aug 19, 2021
Comment thread pygmt/datasets/earth_relief.py Outdated
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@weiji14
weiji14 marked this pull request as ready for review August 20, 2021 11:36
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Aug 20, 2021
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 21, 2021
@seisman
seisman merged commit 7a94b68 into GenericMappingTools:main Aug 21, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify resolutions of Earth relief grids requiring the region parameter

4 participants