Fix pylint 2.11 consider-using-f-string checker errors - #1517
Merged
Conversation
weiji14
marked this pull request as ready for review
September 17, 2021 05:57
seisman
approved these changes
Sep 17, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…gTools#1517) * Use f-strings throughout the project * Fix C0201 consider-iterating-dictionary * Fix W1514 unspecified-encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Pylint v2.11.1 released on 17 Sep 2021 added a few more checks, most notably, a recommendation to use f-strings (C0209), and a couple of other ones.
Luckily there was a tool called
flyntthat semi-automatically did the f-string conversion, so I only had to manually change some that weren't caught. Let me know if you find any more!Also made some edits where
dict.keys()was not required anymore, and a missing encoding frompathlib.Path.read_text()Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version