DOC: Use other image (not the GMT logo) in the gallery example for Figure.image #3863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnefroehlich
added
documentation
michaelgrund
approved these changes
Mar 19, 2025
seisman
reviewed
Mar 19, 2025
examples/gallery/images/image.py
Outdated
| Path("gmt-logo.png").unlink() | ||
| # Place and center ("+jCM") an image provided by GMT to the position ("+g") 1/1 on the | ||
| # current plot, scaled up to be 8 cm wide ("+w") and draw a rectangular border around it | ||
| fig.image(imagefile="@needle.jpg", position="g1/1+w8c+jCM", box=True) |
There was a problem hiding this comment.
I prefer to use a URL to an image instead to show that PyGMT supports URLs.
yvonnefroehlich
commented
Mar 19, 2025
examples/gallery/images/image.py
Outdated
| fig.image( | ||
| imagefile="https://www.generic-mapping-tools.org/_static/gmt-logo.png", | ||
| position="g1/1+w3c+jCM", | ||
| imagefile="https://www.emirates247.com/polopoly_fs/1.569712.1452551297!/image/image.jpg", |
There was a problem hiding this comment.
I added a URL to this image. However, not sure how this is about the copyright and using this image in this gallery example.
seisman
reviewed
Mar 19, 2025
Co-authored-by: Dongdong Tian <[email protected]>
yvonnefroehlich
changed the title
Figure.image
seisman
reviewed
Mar 19, 2025
seisman
approved these changes
Mar 19, 2025
seisman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Related to the second part of comment #3856 (comment).
Update the gallery example for
Figure.imageto use another image (not the GMT logo).Preview:
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code