AliasSystem: Migrate the region parameter to the new alias system #4099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
force-pushed
the
AliasSystem/region
branch
from
22554ee to
3ffb81d
Compare
seisman
force-pushed
the
AliasSystem/region
branch
from
3ffb81d to
1944b41
Compare
seisman
commented
Sep 23, 2025
| case "J": | ||
| alias = Alias(value, name="projection") | ||
| case "R": | ||
| alias = Alias(value, name="region", sep="/", size=(4, 6)) |
There was a problem hiding this comment.
The size is usually 4, but can be 6 for 3-D plots.
| >>> landmask = pygmt.grdlandmask(spacing=1, region=[125, 130, 30, 35]) | ||
| """ | ||
| if kwargs.get("I") is None or kwargs.get("R") is None: | ||
| if kwargs.get("I") is None or kwargs.get("R", region) is None: |
There was a problem hiding this comment.
Check if region/R is not specified.
seisman
added
final review call
yvonnefroehlich
approved these changes
Sep 29, 2025
seisman
removed
the
final review call
seisman
added a commit
that referenced
this pull request
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.