Skip to content

Migrate baseline images from DVC to Git LFS - #4740

Merged
seisman merged 12 commits into
mainfrom
dvc2lfs
Jul 22, 2026
Merged

Migrate baseline images from DVC to Git LFS#4740
seisman merged 12 commits into
mainfrom
dvc2lfs

Conversation

@seisman

@seisman seisman commented Jul 21, 2026

Copy link
Copy Markdown
Member

Adresses: #4738

  • Track pygmt/tests/baseline/*.png using Git LFS
  • Remove all *.dvc files
  • Remove dvc from environment.yml
  • Remove .dvc/ and .dvcignore
  • Update MANIFEST.in
  • Update the Maintainers' Guide
  • Update the Contributors' Guide
  • Remove the dvc-diff.yml workflow, because GitHub can display diffs for LFS-tracked images directly in the web UI
  • Remove the cache_dvc.yaml workflow, which was added as a workaround for Running "dvc pull" now requires authentication #4147
  • Update the style_checks.yaml workflow
  • Update the ci_tests.yaml workflow
  • Update the ci_tests_dev.yaml workflow
  • Update the release-baseline-image.yml workflow
  • Ensure that source and binary distributions do not include the baseline images (run make package and ensure that the files have no PNG images).

@seisman seisman added maintenance Boring but important stuff for the core devs run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels Jul 21, 2026
@seisman seisman added this to the 0.20.0 milestone Jul 21, 2026
@seisman
seisman marked this pull request as ready for review July 21, 2026 06:13
@seisman seisman added the needs review This PR has higher priority and needs review. label Jul 21, 2026
@seisman

seisman commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

The migration from DVC to Git LFS turned out to be much simpler than I initially expected. This PR completes the migration, with the only exception being updates to the Contributors’ Guide. I think those documentation changes will be easier to review in a separate PR.

@seisman
seisman requested a review from weiji14 July 21, 2026 06:16

@weiji14 weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman, glad to see all the gh actions workflows getting cleaned up, and less workarounds to maintain! I haven't checked through all the 200+ hashes, but trust that it is ok since CI is fine.

Just remember to delete the DAGSHUB_TOKEN from https://github.com/GenericMappingTools/pygmt/settings/secrets/actions after merging, and to update the doc/contributing.md later as mentioned.

@seisman
seisman merged commit 1b1fcb8 into main Jul 22, 2026
29 of 41 checks passed
@seisman
seisman deleted the dvc2lfs branch July 22, 2026 02:38
@seisman seisman removed needs review This PR has higher priority and needs review. run/test-gmt-dev Trigger the GMT Dev Tests workflow in PR labels Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants