CI: Install ninja to speed up building GMT source code - #986
Merged
Conversation
seisman
marked this pull request as ready for review
March 2, 2021 04:05
seisman
added
maintenance
seisman
commented
Mar 2, 2021
Comment on lines
-82
to
+84
| run: conda install cmake libblas libcblas liblapack fftw gdal ghostscript libnetcdf hdf5 zlib curl pcre ipython pytest pytest-cov pytest-mpl | ||
| run: | | ||
| conda install ninja cmake libblas libcblas liblapack fftw gdal ghostscript \ | ||
| libnetcdf hdf5 zlib curl pcre ipython pytest pytest-cov pytest-mpl |
Member
Author
There was a problem hiding this comment.
I added ninja and also split the long command into two lines.
weiji14
approved these changes
Mar 2, 2021
weiji14
left a comment
weiji14
left a comment
Member
There was a problem hiding this comment.
Nice speedup on the benchmarks!
Member
|
Actually, just noticed that total CI time on macOS is still 15 min before and after. But that's ok I guess since Linux is still faster by 1 minute. |
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
With the upstream PR GenericMappingTools/gmt#4883 merged, it's possible to use ninja to build GMT, which is much faster.
We only need to install
ninja.Without ninja (https://github.com/GenericMappingTools/pygmt/actions/runs/612306243), building GMT takes ~3.5 minutes on Linux and ~8.5 minutes on macOS.
Now (https://github.com/GenericMappingTools/pygmt/actions/runs/612798172), it takes ~2.5 minutes on Linux and 5 minutes on macOS.
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version