Skip to content

[Fixes #13087] Remove flower - this comes from old monitoring solution #13060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

ffischer1984
Copy link

@ffischer1984 ffischer1984 commented Apr 10, 2025

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Copy link

cla-bot bot commented Apr 10, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Fabian Fischer.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (17b3925) to head (5962be5).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13060      +/-   ##
==========================================
+ Coverage   61.96%   67.97%   +6.01%     
==========================================
  Files         980      980              
  Lines       59303    59303              
  Branches     6932     6932              
==========================================
+ Hits        36745    40314    +3569     
+ Misses      20976    17340    -3636     
- Partials     1582     1649      +67     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattiagiupponi
Copy link
Contributor

@giohappy i agree with this, can we merge?

@Gpetrak
Copy link
Contributor

Gpetrak commented Apr 11, 2025

@mattiagiupponi I agree too, I added the backport 4.4.x label so if the changes are acceptable, they will be applied on 4.4.x also.

@giohappy
Copy link
Contributor

@Gpetrak please add an issue and fix the title accoridngly.

@Gpetrak Gpetrak added the dependencies Pull requests that update a dependency file label Apr 15, 2025
@Gpetrak Gpetrak linked an issue Apr 15, 2025 that may be closed by this pull request
@Gpetrak Gpetrak changed the title remove flower - this comes from old monitoring solution [FIXIES #13087] Remove flower - this comes from old monitoring solution Apr 15, 2025
@Gpetrak Gpetrak changed the title [FIXIES #13087] Remove flower - this comes from old monitoring solution [FIXES #13087] Remove flower - this comes from old monitoring solution Apr 15, 2025
@giohappy giohappy changed the title [FIXES #13087] Remove flower - this comes from old monitoring solution [Fixes #13087] Remove flower - this comes from old monitoring solution Apr 15, 2025
@Gpetrak Gpetrak requested a review from giohappy April 15, 2025 08:14
@giohappy giohappy merged commit e33244e into GeoNode:master Apr 15, 2025
18 of 19 checks passed
@Gpetrak
Copy link
Contributor

Gpetrak commented Apr 15, 2025

@Gpetrak please add an issue and fix the title accoridngly.

@giohappy done

@giohappy
Copy link
Contributor

FYI the base image has been rebuilt and published to Docker Hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.4.x dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Flower, a monitoring tool for Celery
4 participants