-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fixes #13125: Reopen in container for development is not working #13276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13276 +/- ##
==========================================
- Coverage 72.58% 72.58% -0.01%
==========================================
Files 917 917
Lines 52713 52713
Branches 6063 6063
==========================================
- Hits 38263 38261 -2
- Misses 12888 12891 +3
+ Partials 1562 1561 -1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once started, I see the following folders in the file explorer:
geonodepython3.10folder containingGrammarand `Parser
Not sure why devcontainer is not dropping me into geonode. I neither do not know what python3.10 actually serves here.
Starting GeoNode via the documented launch.json prints the following warnings:
/usr/local/lib/python3.10/dist-packages/polymorphic/__init__.py:9: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
import pkg_resources
/usr/local/lib/python3.10/dist-packages/polymorphic/__init__.py:9: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
import pkg_resources
I am pretty sure, that I have seen this before but cannot grab from the top of my head unfortunately.
|
|
||
| - In the vscode terminal, you’re going to see something similar to root@77e80acc89b8:/usr/src/geonode#. | ||
|
|
||
| - To run your application, you can use the integrated terminal (./manage.py runserver 0.0.0.0:8000) or the vscode “Run and Debug” option. For launching with “Run and Debug”, generate the following files in the `.vscode` folder inside the `.devcontainer` folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd propose to have a default .vscode/launch.json available. You would have to re-create it after every rebuild. In addition one can just hit "shortcut of choice" to start up instantly. And finally, you could remove the instruction from the documentation as well :).
.devcontainer/docker-compose.yml
Outdated
|
|
||
| volumes: | ||
| - '.:/usr/src/geonode' | ||
| - './.devcontainer/.vscode:/usr/src/.vscode' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives me an empty .vscode folder .. Why not adding it with some reasonable default files, like launch.json (similar to here: https://github.com/GeoNodeUserGroup-DE/geonode-blueprint-docker/tree/main/.devcontainer/_vscode)
ref #13125
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.