Skip to content

Conversation

@mattiagiupponi
Copy link
Contributor

ref #13125

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi added this to the 5.0.0 milestone Jun 16, 2025
@mattiagiupponi mattiagiupponi requested a review from giohappy June 16, 2025 16:05
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jun 16, 2025
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.58%. Comparing base (721f1d2) to head (207c184).
⚠️ Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13276      +/-   ##
==========================================
- Coverage   72.58%   72.58%   -0.01%     
==========================================
  Files         917      917              
  Lines       52713    52713              
  Branches     6063     6063              
==========================================
- Hits        38263    38261       -2     
- Misses      12888    12891       +3     
+ Partials     1562     1561       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattiagiupponi mattiagiupponi requested a review from ridoo July 21, 2025 10:24
Copy link
Contributor

@ridoo ridoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once started, I see the following folders in the file explorer:

  • geonode
  • python3.10 folder containing Grammar and `Parser

Not sure why devcontainer is not dropping me into geonode. I neither do not know what python3.10 actually serves here.

Starting GeoNode via the documented launch.json prints the following warnings:

/usr/local/lib/python3.10/dist-packages/polymorphic/__init__.py:9: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  import pkg_resources
/usr/local/lib/python3.10/dist-packages/polymorphic/__init__.py:9: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  import pkg_resources

I am pretty sure, that I have seen this before but cannot grab from the top of my head unfortunately.


- In the vscode terminal, you’re going to see something similar to root@77e80acc89b8:/usr/src/geonode#.

- To run your application, you can use the integrated terminal (./manage.py runserver 0.0.0.0:8000) or the vscode “Run and Debug” option. For launching with “Run and Debug”, generate the following files in the `.vscode` folder inside the `.devcontainer` folder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose to have a default .vscode/launch.json available. You would have to re-create it after every rebuild. In addition one can just hit "shortcut of choice" to start up instantly. And finally, you could remove the instruction from the documentation as well :).


volumes:
- '.:/usr/src/geonode'
- './.devcontainer/.vscode:/usr/src/.vscode'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives me an empty .vscode folder .. Why not adding it with some reasonable default files, like launch.json (similar to here: https://github.com/GeoNodeUserGroup-DE/geonode-blueprint-docker/tree/main/.devcontainer/_vscode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 4.4.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants