-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Fixes #13507] Refactor of the create dataset page #13580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13580 +/- ##
==========================================
+ Coverage 72.52% 72.56% +0.04%
==========================================
Files 931 932 +1
Lines 55216 55469 +253
Branches 7437 7474 +37
==========================================
+ Hits 40044 40250 +206
- Misses 13569 13606 +37
- Partials 1603 1613 +10 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattiagiupponi I noticed the following while testing:
- error creating a dataset using an attribute with initial letter uppercase
Dataset could not be created in GeoServer The CQL source expression for attribute A refers to attributes unavailable in the data source: [A]. Request: d3bdac0a-f543-4530-9b25-88308e657e68
curl 'http://localhost/api/v2/uploads/upload' \
-H 'Accept: application/json, text/plain, */*' \
-H 'Accept-Language: en-US,en;q=0.9' \
-H 'Cache-Control: no-cache' \
-H 'Connection: keep-alive' \
-H 'Content-Type: application/json' \
-H 'Origin: http://localhost:8081' \
-H 'Pragma: no-cache' \
-H 'Sec-Fetch-Dest: empty' \
-H 'Sec-Fetch-Mode: cors' \
-H 'Sec-Fetch-Site: same-origin' \
--data-raw '{"action":"create","title":"ffff","geom":"Point","attributes":{"A":{"type":"string","nillable":true}}}'
- Is it possible to skip the thumbnail creation only for the create action workflow? Maybe could this help to speed up the creation of a dataset?
changes / fix pushed |
| return False | ||
|
|
||
|
|
||
| def add_attributes_to_xml(attributes_dict, xml): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattiagiupponi IMHO this should go into geoserver-restconfig. We read restrictions from it, we should write them too.
ref #13507
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.