Skip to content

Conversation

@mattiagiupponi
Copy link
Contributor

ref #13507

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.56%. Comparing base (746dc74) to head (dc85f5a).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13580      +/-   ##
==========================================
+ Coverage   72.52%   72.56%   +0.04%     
==========================================
  Files         931      932       +1     
  Lines       55216    55469     +253     
  Branches     7437     7474      +37     
==========================================
+ Hits        40044    40250     +206     
- Misses      13569    13606      +37     
- Partials     1603     1613      +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattiagiupponi mattiagiupponi marked this pull request as ready for review October 10, 2025 14:51
@mattiagiupponi mattiagiupponi self-assigned this Oct 10, 2025
@mattiagiupponi mattiagiupponi linked an issue Oct 10, 2025 that may be closed by this pull request
@mattiagiupponi mattiagiupponi modified the milestones: 5.1.0, 5 Oct 10, 2025
@giohappy giohappy modified the milestones: 5, 5.0.0 Oct 10, 2025
Copy link
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattiagiupponi I noticed the following while testing:

  • error creating a dataset using an attribute with initial letter uppercase Dataset could not be created in GeoServer The CQL source expression for attribute A refers to attributes unavailable in the data source: [A]. Request: d3bdac0a-f543-4530-9b25-88308e657e68
curl 'http://localhost/api/v2/uploads/upload' \
  -H 'Accept: application/json, text/plain, */*' \
  -H 'Accept-Language: en-US,en;q=0.9' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: application/json' \
  -H 'Origin: http://localhost:8081' \
  -H 'Pragma: no-cache' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  --data-raw '{"action":"create","title":"ffff","geom":"Point","attributes":{"A":{"type":"string","nillable":true}}}'
  • Is it possible to skip the thumbnail creation only for the create action workflow? Maybe could this help to speed up the creation of a dataset?

@mattiagiupponi
Copy link
Contributor Author

@mattiagiupponi I noticed the following while testing:

  • error creating a dataset using an attribute with initial letter uppercase Dataset could not be created in GeoServer The CQL source expression for attribute A refers to attributes unavailable in the data source: [A]. Request: d3bdac0a-f543-4530-9b25-88308e657e68
  • Is it possible to skip the thumbnail creation only for the create action workflow? Maybe could this help to speed up the creation of a dataset?

changes / fix pushed

return False


def add_attributes_to_xml(attributes_dict, xml):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattiagiupponi IMHO this should go into geoserver-restconfig. We read restrictions from it, we should write them too.

@giohappy giohappy self-requested a review October 28, 2025 16:55
@giohappy giohappy merged commit 341d050 into master Oct 28, 2025
17 checks passed
@giohappy giohappy deleted the ISSUE_13507 branch October 28, 2025 16:56
@mattiagiupponi mattiagiupponi removed this from the 5.0.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor of the create dataset page

4 participants